Closed Bug 8657 Opened 25 years ago Closed 22 years ago

Fix numerous compiler warnings in libimg

Categories

(Core :: Graphics: ImageLib, defect, P3)

x86
Windows NT
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: David.R.Gardiner, Assigned: pnunn)

Details

Attachments

(8 files)

Files in modules\libimg\ pngcom\png_png.cpp(30) warning C4005: 'ERROR' : macro redefinition src\ilclient.cpp(373) : warning C4018: '!=' : signed/unsigned mismatch src\ilclient.cpp(374) : warning C4018: '!=' : signed/unsigned mismatch src\ilclient.cpp(438) : warning C4101: 'result' : unreferenced local variable src\il_util.cpp(103) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data src\il_util.cpp(104) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data src\il_util.cpp(105) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data src\il_util.cpp(109) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data src\il_util.cpp(116) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data src\il_util.cpp(118) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data src\il_util.cpp(120) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data src\il_util.cpp(306) : warning C4244: '=' : conversion from 'long' to 'unsigned char', possible loss of data src\scale.cpp(208) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned short', possible loss of data src\scale.cpp(698) : warning C4018: '>=' : signed/unsigned mismatch src\scale.cpp(724) : warning C4018: '!=' : signed/unsigned mismatch src\scale.cpp(730) : warning C4018: '>=' : signed/unsigned mismatch src\scale.cpp(751) : warning C4018: '!=' : signed/unsigned mismatch src\scale.cpp(757) : warning C4018: '>=' : signed/unsigned mismatch Patches use casts to fix compiler warnings.
Attached patch Fix redefine of ERROR (deleted) — Splinter Review
Attached patch Fix warnings (deleted) — Splinter Review
Attached patch Patch to fix warnings (deleted) — Splinter Review
Attached patch Patch to fix warnings (deleted) — Splinter Review
Attached patch Patch to fix if_struct.h (deleted) — Splinter Review
Status: NEW → ASSIGNED
Severity: normal → minor
Target Milestone: M10
Target Milestone: M10 → M14
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → LATER
pnunn/neeti, are there any problems with the submitted patches, or why is this being resolved as LATER? Thanks!
Most of these probably have been fixed, but I don't have time to verify. -p
Status: RESOLVED → VERIFIED
david.gardiner@unisa.edu.au, I'm going to resolve this bug as VERIFIED/LATER. Although I know it's an imposition and do apologize, if you'd like to determine which of these compiler warnings are still relevant and confirm that the patches are still relevant, please feel free to.
LATER is deprecated.
Status: VERIFIED → REOPENED
Resolution: LATER → ---
WONTFIX. libimg is dead.
Status: REOPENED → RESOLVED
Closed: 25 years ago22 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: