Closed
Bug 86633
Opened 23 years ago
Closed 23 years ago
display:none doesn't work with <form>
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
VERIFIED
FIXED
Future
People
(Reporter: basic, Assigned: rods)
References
Details
(Keywords: regression, Whiteboard: [CSS1-5.6.1])
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
In the to be attached testcase, the <form> element is suppost to be hidden.
Forgot to mentioned that I'm testing this with build 2001061804 win32
Comment 3•23 years ago
|
||
error shows on linux 2001 06 18 21
Comment 4•23 years ago
|
||
This works on 2001060712, incidentally, so it was broken fairly recently.
Keywords: regression
Comment 5•23 years ago
|
||
Reassigned to HTML Form Controls
Assignee: pierre → rods
Component: Style System → HTML Form Controls
QA Contact: ian → madhur
Comment 7•23 years ago
|
||
Nope, though I'm interested in it. I was <I>wondering</I> why setting the form
to display: none wasn't making it go away.
Keywords: mozilla1.0
Assignee | ||
Comment 8•23 years ago
|
||
*** This bug has been marked as a duplicate of 34297 ***
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Comment 9•23 years ago
|
||
This is not a dup ... 34297 is about submitting form controls, and this one is
about laying out <form>. It's not fixed in 34297 and really should be
considered a separate issue (i.e. <form style="display: none"> does not hide the
form).
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 10•23 years ago
|
||
John, I am futuring this, but you are welcome to take.
Status: REOPENED → ASSIGNED
Target Milestone: --- → Future
Comment 11•23 years ago
|
||
I believe this is because html.css has:
form {
display: block !important;
}
change to:
form {
display: block;
}
and display: none; is fine.
HOWEVER display: inline on <form> still does not behave correctly (Moz 0.9.7)
Reporter | ||
Comment 12•23 years ago
|
||
Rich, thanks!
Reporter | ||
Comment 13•23 years ago
|
||
Reporter | ||
Comment 14•23 years ago
|
||
posted bug 123470 for display: inline;
Keywords: mozilla0.9.9,
patch
Comment 15•23 years ago
|
||
Please test how "form { display: inline }" works in author sheets with your
patch. :)
Reporter | ||
Comment 16•23 years ago
|
||
I've tested it and found to have no effect. I've a testcase at bug 123470 if
anyone wants to test
Comment 17•23 years ago
|
||
i just noticed, the form declaration in html.css is irrelevant because of rules
in forms.css.
would it be better to remove the rule altogether from html.css?
i tested this on mos 0.9.7.
display:none works. display: inline fails
Reporter | ||
Comment 18•23 years ago
|
||
are the rules in forms.css being used? I thought those were used only if xbl
form elements are turned on or something like that. I've tested almost all the
css display properties that I know will work in moz and they work except for
display: inline;
Comment 19•23 years ago
|
||
The rules in forms.css are being used. I have changed them and they have
affected form control display.
Comment 20•23 years ago
|
||
Rod can you please reconsider fixing this bug.
All that is needed is to remove the !important from the rule (i'd even suggest
removing the rule from the html.css file since it is already included in the
forms.css file).
I will submit a new bug report for the inline problem (with a testcase) if I
can't find a dupe report already submitted because it's a different issue.
Comment 21•23 years ago
|
||
Well I found what caused this regression... bug 62811.
Rod look at comments #31 and #32 you can see that the reason for the bug
report was fixed a different way.
From #32:
Just as a heads up - I plan on removing nsFormFrame as part of bug 34297. I'm
moving all the form submission and management logic to content land, and there
is nothing else of interest in nsFormFrame. This should, I think, eliminate
the need to change html.css.
Again I think that this is safe to remove !important.
BTW: no support for form {display:inline} is bug 44470.
Depends on: 62811
Updated•23 years ago
|
Keywords: mozilla0.9.9
Whiteboard: [CSS1-5.6.1]
Comment 22•23 years ago
|
||
Fixed with bug 125578 (bye bye nsFormFrame).
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Comment 23•23 years ago
|
||
Form element is visible for the testcase being browsed with Mozilla 1.0, Win32
environment.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 24•23 years ago
|
||
It isn't fixed for 1.0 and will not be. Use a trunk build.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Comment 25•22 years ago
|
||
verified fixed on winXP, linux 8.0 and macos 10.1
with testcase attachment 39119 [details]
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•