Closed Bug 881 Opened 26 years ago Closed 26 years ago

BUILD: error building with glibc/gcc 2.8.1

Categories

(MozillaClassic Graveyard :: XFE, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: raff, Assigned: mcafee)

Details

The file lib/xp/xp_trace.c does not compiles when using glibc and gcc 2.8.1 The error is documented in glibc FAQ: -------------------------------------------------------------------------- 3.9. I get compiler messages "Initializer element not constant" with stdin/stdout/stderr. Why? {RM,AJ} Constructs like: static FILE *InPtr = stdin; lead to this message. This is correct behaviour with glibc since stdin is not a constant expression. Please note that a strict reading of ISO C does not allow above constructs. -------------------------------------------------------------------------- Since the variable real_stderr gets initialized in cmd/xfe/mozilla.c:main and in cmd/xfe/src/context_funcs.cpp, there is no point in setting its value here. NOTE: don't ask me why the same assignment in a C++ module (as context_funcs.cpp) works fine :( Index: xp_trace.c =================================================================== RCS file: /cvsroot/mozilla/lib/xp/xp_trace.c,v retrieving revision 3.1 diff -b -r3.1 xp_trace.c 65c65 < FILE *real_stderr = stderr; --- > FILE *real_stderr = NULL;
Assignee: ramiro → mcafee
wtc: can we check this in ? Reassigning to mcafee.
Obviously it is okay for XFE, but we need to check the main() function in WINFE and MACFE and make sure they all set real_stderr to stderr before using it. The "last touched by" owner of that file seems to be either Warren or Waterson.
Summary: BUILD: error building with glibc → BUILD: error building with glibc/gcc 2.8.1
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Looks like this has been checked in for Unix.
QA Contact: 1376
qa contact set to reporter for verify
VERIFIED due to no changes in over a year
Status: RESOLVED → VERIFIED
We don't verify bugs "due to no changes for a year". This is probably fixed, 2.8.1 is pretty old. Let's verify this one, but please stop verifying things w/o taking a look, that's just a bad idea.
You need to log in before you can comment on or make changes to this bug.