Closed Bug 8923 Opened 25 years ago Closed 25 years ago

inserting horizontal line makes caret Jumbo size

Categories

(Core :: DOM: Editor, defect, P3)

x86
Windows 98
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: icos, Assigned: mozeditor)

References

Details

Start the editor either thru -edit or with the tasks menu. before doing anything else, hit the "H Line" button to insert a horizontal line. Wow, look at the size of that caret! June 26 build.
Status: NEW → ASSIGNED
Target Milestone: M8
Assignee: buster → sfraser
Status: ASSIGNED → NEW
assigned to simon. Consider the case when the selection can't be text, like when the document contains only HRs and images: what's our plan?
Assignee: sfraser → cmanske
The insert HR transaction needs to set the selection properly after inserting the HR.
*** Bug 8773 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Target Milestone: M8 → M9
There is no "insert HR transaction". I'm using nsEditor::InsertNode, which uses the transaction system. Shouldn't it manage the selection properly?
Assignee: cmanske → sfraser
Status: ASSIGNED → NEW
Simon fixed this problem for most cases, but there's still a problem when the element inserted is at the end of a paragraph. In that case we stil get the big caret, probably because there is no "next sibling" of the newly-inserted element. Simon: maybe you should search for a textnode previous to the inserted element if their is no node at the selection anchor=node+offset? I'll let Simon sort this out.
I believe this is a similar problem to that described in bug 10683.
Status: NEW → ASSIGNED
Target Milestone: M9 → M10
Target Milestone: M10 → M11
Assignee: sfraser → jfrancis
Status: ASSIGNED → NEW
I'm not entirely sure that this is a caret issue, since typing in that situation behaves oddly too (more vertical space suddenly shows up). Behaviour also depends on what was split to make the <hr>. This seems related to the end-of-doc case. Since it looks more like a typing issue, I'm giving it to joe. If you disagree, joe, please bounce it back.
Status: NEW → ASSIGNED
Target Milestone: M11 → M12
M12, dude.
I love it... m9, to m10, to m11, to m12.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
This bug is mostly fixed. There are still cases, I think, where you can get the uber caret. But they are a lot rarer now and I would prefer to close this bug and open new ones against specific remaining scenarios that cause trouble. Note that there is a seperate bug (20106) about the caret disappearing. That bug may make it difficult for you to verify this one.
Status: RESOLVED → VERIFIED
verified in 11/29 build.
You need to log in before you can comment on or make changes to this bug.