Closed Bug 919 Opened 26 years ago Closed 26 years ago

BUILD: ptio.c always uses poll() and related macros

Categories

(NSPR :: NSPR, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: raff, Assigned: wtc)

Details

If building with USE_PTHREADS=1 the module nsprpub/pr/src/pthreads/ptio.c get compiled with a call to _MD_unix_map_poll_error (macro _PR_MD_MAP_POLL_ERROR) that is currently undefined for linux (see nsprpub/pr/include/md/_linux.h). The code should probably check for _PR_USE_POLL.
This is a known build problem after the NSPR v3.0 beta landing. The patch has been posted to the mozilla.patches or mozilla.builds newsgroup. I need more testing before I check in the patch, but until then you can edit mozilla/nsprpub/pr/include/md/_linux.h and change #undef _PR_POLL_AVAILABLE to #if defined(__GLIBC__) && __GLIBC__ >= 2 #define _PR_POLL_AVAILABLE #endif Sorry for the inconvenience. This will be fixed by Sept. 30. The reason I haven't checked it in is that the NSPR v3.0 beta landing was not as smooth as I hoped, and to open the tree (so that the poor release engineers can go home) I had to make all the Tinderbox continuous builds work. So under the time pressure I had to check in something that just fix the non-pthreads (the default) build breakage, at the cost of breaking the pthreads build (which I actually noticed right away but did not want to check in another hasty fix).
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
The fix I described earlier has been checked in.
QA Contact: 1376
qa contact set to reporter for verify
NSPR now has its own Bugzilla product. Moving this bug to the NSPR product.
VERIFIED due to no changes in over a year
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.