Closed
Bug 92837
Opened 23 years ago
Closed 23 years ago
ftp upload api missing
Categories
(Core :: Networking: FTP, defect)
Core
Networking: FTP
Tracking
()
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: Brade, Assigned: dougt)
References
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
There is no way to upload a file via ftpchannel.
This is blocking publishing and ftp upload within browser.
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
bradley, can you review please - Darin sr?
Assignee | ||
Comment 3•23 years ago
|
||
in stor:
+ // need to skip over the inital sperator
+ const char* buffer = mPath.get();
+ if (buffer && buffer[0]=='/')
+ buffer++;
+ storStr.Append(buffer);
is wrong, I am suppose to just send mPath.get()
Assignee | ||
Comment 4•23 years ago
|
||
Comment 5•23 years ago
|
||
you've removed all use of mWriteCount, so you should remove it from the class
declaration as well.
r=bbaetz with that change.
Assignee | ||
Comment 6•23 years ago
|
||
good catch. thanks. darin/gagan, sr please?
Comment 7•23 years ago
|
||
looks good (sr=darin) modulo one nit:
+ NS_IF_ADDREF(*stream = mUploadStream);
should be:
*stream = mUploadStream;
NS_ADDREF(*stream);
otherwise, you're assigning *stream twice.
Comment 8•23 years ago
|
||
let me correct myself:
*stream = mUploadStream;
NS_IF_ADDREF(*stream);
:-)
Assignee | ||
Comment 9•23 years ago
|
||
Fix checked in.
Checking in public/nsIFTPChannel.idl;
/cvsroot/mozilla/netwerk/protocol/ftp/public/nsIFTPChannel.idl,v <--
nsIFTPChannel.idl
new revision: 1.13; previous revision: 1.12
done
Checking in src/nsFTPChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFTPChannel.cpp,v <-- nsFTPChannel.cpp
new revision: 1.105; previous revision: 1.104
done
Checking in src/nsFTPChannel.h;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFTPChannel.h,v <-- nsFTPChannel.h
new revision: 1.62; previous revision: 1.61
done
Checking in src/nsFtpConnectionThread.cpp;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp,v <--
nsFtpConnectionThread.cpp
new revision: 1.185; previous revision: 1.184
done
Checking in src/nsFtpConnectionThread.h;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.h,v <--
nsFtpConnectionThread.h
new revision: 1.81; previous revision: 1.80
done
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 10•23 years ago
|
||
i could not find FILE>UPLOAD or FILE>PUT on the browser. how can i upload a file.
i am using 091904 linux build.
Comment 11•23 years ago
|
||
stummala@netscape.com: you can't, since there is no UI for that feature yet.
Reporter | ||
Comment 12•23 years ago
|
||
see bug #24867 for UI
I am verifying this bug since I have been able to successfully ftp upload with
Composer in my debug build.
Blocks: 24867
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•