Closed
Bug 9588
Opened 25 years ago
Closed 25 years ago
FinalizeInstall() doesn't check or return error codes
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: dveditz, Assigned: dveditz)
Details
The last half of FinalizeInstall() is totally hosed.
- The error status of ie->Complete() isn't checked.
- Any non-zero value causes abort, no provision for "reboot needed" value
- Doesn't call "CleanUp()" in the successful case, leaking memory big time
- If it fails it aborts() that one item, but not the rest of the queue
(leaving temp files lying all over the disk)
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•25 years ago
|
||
I think I've fixed this one along with my 8311 changes (needed finalize to
return a value so I could have a value to pass back to the call-back).
Not checked-in, waiting for permission.
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Build 1999-10-18-09-M11(WIN), 1999-10-18-12-M11(MAC), 1999-10-18-08-M11(LINUX)
We're good.
Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•