Closed Bug 9733 Opened 25 years ago Closed 25 years ago

[CODE] Missing call to remove content->frame mapping

Categories

(Core :: Layout, defect, P2)

Product:
Core
Component:
Layout
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: troy, Assigned: troy)

Details

(Whiteboard: fix ready to go on branch)

When handling images that can't be rendered, the frame construction code throws away the image frame and creates a new frame. The hash table mapping is not being updated, and so the hash table entry points to the now deleted frame
Severity: normal → major
Status: NEW → ASSIGNED
Priority: P3 → P2
Target Milestone: M8
Whiteboard: fix ready to go on branch.
troy has a fix. Index: nsCSSFrameConstructor.cpp =================================================================== RCS file: /cvsroot/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,v retrieving revision 1.149 diff -r1.149 nsCSSFrameConstructor.cpp 5452a5455,5458 > // Reset the primary frame mapping > presShell->SetPrimaryFrameFor(content, newFrame); > > // Insert the new frame
checked into M8_BRANCH
Thanks Chris for checking it into the branch. I'll be checking the change in to top-of-trunk (when it opens), and it's the same change but I re-ordered the code slightly to make it clearer. I wanted to ake sure you knew in case you were thinking on adding the change to the tip as well
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Checked into tip
Whiteboard: fix ready to go on branch. → fix ready to go on branch; QA will verify in July 15th Build.
Based on troy's comments, I will check in the next build (July 15th).
Based on troy's comments, I will check in the next build (July 15th).
Status: RESOLVED → VERIFIED
Whiteboard: fix ready to go on branch; QA will verify in July 15th Build. → fix ready to go on branch
Fixed in the July 14th Build (1999071417)
You need to log in before you can comment on or make changes to this bug.