Closed Bug 9964 Opened 25 years ago Closed 25 years ago

nsSoftwareUpdate class need to be a singleton

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

nsSoftwareUpdate class need to be a singleton for blocking to work. Here is the diff: RCS file: /cvsroot/mozilla/xpinstall/src/nsSoftwareUpdate.cpp,v retrieving revision 1.25 diff -r1.25 nsSoftwareUpdate.cpp 85a86,99 > nsSoftwareUpdate* nsSoftwareUpdate::mInstance = nsnull; > > > nsSoftwareUpdate * > nsSoftwareUpdate::GetInstance() > { > if (mInstance == NULL) > { > mInstance = new nsSoftwareUpdate(); > } > return mInstance; > } > > 371c388 < nsSoftwareUpdate *inst = new nsSoftwareUpdate(); --- > nsSoftwareUpdate *inst = nsSoftwareUpdate::GetInstance(); and Index: nsSoftwareUpdate.h =================================================================== RCS file: /cvsroot/mozilla/xpinstall/src/nsSoftwareUpdate.h,v retrieving revision 1.14 diff -r1.14 nsSoftwareUpdate.h 27c27 < --- > static nsSoftwareUpdate *GetInstance(); 48c48 < --- > static nsSoftwareUpdate* mInstance; I am not sure why this was never done
Summary: nsSoftwareUpdate class need to be a singleton
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
this has been checked in. closing.
Status: RESOLVED → VERIFIED
7/22/99 I've confirmed the checkins.
Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall Engine
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.