Closed
Bug 9968
Opened 25 years ago
Closed 25 years ago
Remove temporary code from sort key creation
Categories
(MailNews Core :: Internationalization, defect, P3)
MailNews Core
Internationalization
Tracking
(Not tracked)
VERIFIED
FIXED
M9
People
(Reporter: nhottanscp, Assigned: mozilla)
Details
Bug 3867 was fixed in April. We should use real locale for sort key creation.
Should I fix this or assign to mail/news eng?
Below is a search result of lxr.mozilla.org, searched 'bug#3867'.
/rdf/content/src/nsXULSortService.cpp, line 278 -- // Temporary: pass null until
bug#3867 is fixed
/mailnews/db/msgdb/src/nsMsgDatabase.cpp, line 2032 -- err =
f->CreateCollation(nsnull/*locale*/, &inst); // Temporary: pass null until
bug#3867 is fixed
Reporter | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M9
Reporter | ||
Comment 1•25 years ago
|
||
I am going to check in for msgdb today.
Looks like XUL one needs more investigation.
Does anyone know who should I contact?
Comment 2•25 years ago
|
||
rjc worked on the sort service.
Reporter | ||
Comment 3•25 years ago
|
||
I checked in the change for msgdb.
Reassigning to rjc for XUL change. I don't know where it is used so not sure if
the target milestone is appropriate.
Regarding the locale creation, I don't recommend to create locale per sort key
(see 8822).
Assignee: nhotta → rjc
Status: ASSIGNED → NEW
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•25 years ago
|
||
Fixed.
Comment 5•25 years ago
|
||
For Mail, an ideal place to verify this would be in the thread pane
headers sorting, but there is Bug 8455 which makes is undesirable
to verify it at this time.
For XUL, I would like to know where rjc is calling the locale
sensitive sorting routine. Could you list one or more
places where there will be a difference?
Assignee | ||
Comment 6•25 years ago
|
||
locale is only used with sorting with collation keys and, at the moment, only
mail/news uses collation keys.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 7•25 years ago
|
||
** Checked with 10/6/99 Win32 M10 final candidate build **
Locale sensitive sort has been working well in the Mail thread pane
fodler and Address Book for some time now. These would be indirect
but proof enough for verifying this fix.
Marking it verified fixed.
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•