Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Description • 12 years ago

what should _fetchWellKnown do if we are off-line?

	Andrew Overholt [:overholt]
	Comment 1 • 12 years ago

Ben, who should own this work?

	Ben Adida [:benadida]
	Comment 2 • 12 years ago

The key issue here is making sure that when a packaged app calls navigator.id.*, that a proper "you are offline" dialog is provided.

	Jason Smith [:jsmith]
	Comment 3 • 12 years ago

Is this a feature or a bug? If it's a feature, this needs to be a minus per today's discussion in the b2g meeting.

	Jason Smith [:jsmith]
	Comment 4 • 12 years ago

(In reply to Jason Smith [:jsmith] from comment #3)
> Is this a feature or a bug? If it's a feature, this needs to be a minus per
> today's discussion in the b2g meeting.

Ignore my comment here. This was a point of confusion on my part.

	Andrew Overholt [:overholt]
	Comment 5 • 12 years ago

Fixing up blocker flag as per comment #4.

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 6 • 12 years ago

Related reading: off-line support for marketplace: https://bugzilla.mozilla.org/show_bug.cgi?id=768946

Kumar pointed me to this: http://dvcs.w3.org/hg/dap/raw-file/tip/network-api/Overview.html

So we should be able to display a message if (navigator.connection.bandwidth === 0).  

I'm not sure how to write a test for that, though.

	Jason Smith [:jsmith]
	Comment 7 • 12 years ago

This is marked as a blocker for ship. However, I'm not sure if there's a user story called out that links to this feature. Josh - Is there an existing user story this bug would map to? If not, do we need a user story for this?

	Jason Smith [:jsmith]
	Comment 8 • 12 years ago

So is the user story here basically "throw up an error if we're offline?" Something like:

As a user, I need to be notified when logging into persona that I do not network connection, so that I know I need to connect to the network to login into persona.

	Jason Smith [:jsmith]
	Comment 9 • 12 years ago

If that looks good, I'll add it as PAYANDID-029.

	Alex Keybl [:akeybl]
	Comment 10 • 12 years ago

We're marking this bug with the C1 milestone since it follows the criteria of "unfinished feature work" (see https://etherpad.mozilla.org/b2g-convergence-schedule).

If this work is not finished by Nov19, this bug will need an exception and will be called out at the upcoming Exec Review.

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 11 • 12 years ago

(In reply to Jason Smith [:jsmith] from comment #8)
> So is the user story here basically "throw up an error if we're offline?"
> Something like:
> 
> As a user, I need to be notified when logging into persona that I do not
> network connection, so that I know I need to connect to the network to login
> into persona.

That sounds good to me!

	Josh Carpenter [:jcarpenter]
	Comment 12 • 12 years ago

FWIW, the bug for a generic Gaia offline-error is here: https://bugzilla.mozilla.org/show_bug.cgi?id=796750. 

Specs here (see page 7): https://www.dropbox.com/sh/e9myv1f3xzvc885/GIdFb1HeIB

Excerpt:

> Gaia’s Window Manager receives an “other” (non-fatal) mozbrowseerror event.
> The window manager decides what UI to present in response.
> If the mozbrowsererror was generated by navigator.onLine, then Gaia’s 
> Window Manager presents a default “No connection” error.

I hope that's helpful / relevant :)

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 13 • 12 years ago

(In reply to Josh Carpenter [:jcarpenter] from comment #12)
> FWIW, the bug for a generic Gaia offline-error is here:
> https://bugzilla.mozilla.org/show_bug.cgi?id=796750. 
> 
> Specs here (see page 7):
> https://www.dropbox.com/sh/e9myv1f3xzvc885/GIdFb1HeIB
> 
> Excerpt:
> 
> > Gaia’s Window Manager receives an “other” (non-fatal) mozbrowseerror event.
> > The window manager decides what UI to present in response.
> > If the mozbrowsererror was generated by navigator.onLine, then Gaia’s 
> > Window Manager presents a default “No connection” error.
> 
> I hope that's helpful / relevant :)

Josh, that document is awesome - thanks very much

So if the WindowManager catches the nonbrowsererror and displays either the off-line or airplane-mode error itself, is it actually necessary for Identity (or Marketplace for that matter) to do anything more?

In other words, is this simply taken care of by gaia?

	Jason Smith [:jsmith]
	Comment 14 • 12 years ago

Spoke with Ben on this one - this doesn't block ship of v1 of the phone. I'm removing the flags as such.

If this does land before the phone ships, feel free to nominate for aurora approval with a risk tradeoff analysis on taking the patch.

	Josh Carpenter [:jcarpenter]
	Comment 15 • 12 years ago

(In reply to Jed Parsons [:jparsons] from comment #13)
> (In reply to Josh Carpenter [:jcarpenter] from comment #12)
> > FWIW, the bug for a generic Gaia offline-error is here:
> > https://bugzilla.mozilla.org/show_bug.cgi?id=796750. 
> > 
> > Specs here (see page 7):
> > https://www.dropbox.com/sh/e9myv1f3xzvc885/GIdFb1HeIB
> > 
> > Excerpt:
> > 
> > > Gaia’s Window Manager receives an “other” (non-fatal) mozbrowseerror event.
> > > The window manager decides what UI to present in response.
> > > If the mozbrowsererror was generated by navigator.onLine, then Gaia’s 
> > > Window Manager presents a default “No connection” error.
> > 
> > I hope that's helpful / relevant :)
> 
> Josh, that document w awesome - thanks very much
> 
> So if the WindowManager catches the nonbrowsererror and displays either the
> off-line or airplane-mode error itself, is it actually necessary for
> Identity (or Marketplace for that matter) to do anything more?
> 
> In other words, is this simply taken care of by gaia?

Hmm, good question. Based on what Alive (cc'd) has shown me in our window.open (PopupManager) implementation, Gaia would generate the "No Connection" or "Airplane Mode" errors, albeit housed within the window.open UI. I suspect the same is true of the Trusted UI contents as well.

WRT to Marketplace, so long as some portion of the app is cached it should be able to launch even in the absence of a connection and these errors would not be seen. From that point on the app would be responsible for communicating connection failures to the user.

cc'd both Alive and Alberto for input here.

I'm not sure how we handle this in the context of Trusted UI contents. Am cc'ing

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 16 • 12 years ago

(In reply to Josh Carpenter [:jcarpenter] from comment #15)
> (In reply to Jed Parsons [:jparsons] from comment #13)
> > Josh, that document w awesome - thanks very much
> > 
> > So if the WindowManager catches the nonbrowsererror and displays either the
> > off-line or airplane-mode error itself, is it actually necessary for
> > Identity (or Marketplace for that matter) to do anything more?
> > 
> > In other words, is this simply taken care of by gaia?
> 
> Hmm, good question. Based on what Alive (cc'd) has shown me in our
> window.open (PopupManager) implementation, Gaia would generate the "No
> Connection" or "Airplane Mode" errors, albeit housed within the window.open
> UI. I suspect the same is true of the Trusted UI contents as well.
> 
> WRT to Marketplace, so long as some portion of the app is cached it should
> be able to launch even in the absence of a connection and these errors would
> not be seen. From that point on the app would be responsible for
> communicating connection failures to the user.
> 
> cc'd both Alive and Alberto for input here.
> 
> I'm not sure how we handle this in the context of Trusted UI contents. Am
> cc'ing

Because UI of normal app and window.open is different, the error event handling is seperated in modal dialog and popup manager. I totally forget we have trustedUI, so it's not implemented now.
But the implementation is not hard.

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 17 • 11 years ago

Ok, time to get this fixed.  I'm working on it now.  Making it dependent on bug 839500 simply so that patches land in the right order.

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 18 • 11 years ago

Here's a little patch to kick off some conversation again.

Focusing on persona on the gaia side, this patch helps in the following scenarios:

- Fixes: A native application that calls navigator.mozId directly is started when there is no network.  watch() callbacks will be successfully invoked, but it will be impossible to get automatic assertions.  When network is re-enabled, the application can request an assertion.  (Use UI Tests -> navigator.mozId suite as an example).

- Fixes: A web-based application (e.g., notoriousb2g.123done.org) loads, but network drops while watch() is being called.  Once network is restored, the web page can be reloaded and persona login will work properly.

- Does not fix: If the trusted ui is open, hosting the persona iframe, and network drops, clicking "sign in" will raise the vague "There has been an error" error in the dialog.  This can't be fixed in gaia; should be fixed in the persona dialog itself.

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 19 • 11 years ago

Comment on attachment 724134 [details] [diff] [review]
gaia patch - gracefully abort persona functions if offline

Ben, I think this addresses a lot of our issues.  At the very least, we should be handling mozbrowsererror.  Thoughts?

	Ben Adida [:benadida]
	Comment 20 • 11 years ago

Comment on attachment 724134 [details] [diff] [review]
gaia patch - gracefully abort persona functions if offline

Review of attachment 724134 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks good. Is offline the only possible cause of mozbrowsererror? Should you be dispatching that chrome event as the first thing?

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 21 • 11 years ago

(In reply to Ben Adida [:benadida] from comment #20)
> Comment on attachment 724134 [details] [diff] [review]
> gaia patch - gracefully abort persona functions if offline
> 
> Review of attachment 724134 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think this looks good. Is offline the only possible cause of
> mozbrowsererror? Should you be dispatching that chrome event as the first
> thing?

It's not the only possible cause, no.  mozbrowsererror is fired if there's an error trying to load the content into the iframe, and that includes the off-line case.  We should be listening for this event regardless.

As for dispatching the chrome event first thing, I think it's ok, since no other modules should be interacting with the iframe directly, but to be on the safer side, I can send the message after removing the frame.

	Jared Hirsch [:jhirsch] (he/him) (Needinfo please)
	Comment 22 • 10 years ago

Hey Jed, would you mind summarizing what we're doing with this bug?

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 23 • 10 years ago

I've been wondering the same thing :)

I'm buried under a few blocker bugs atm.  I can try to resuscitate this soon and see if there's anything we should be doing that isn't already being handled either by the browser or by the persona/trusted_ui error checking.

	Ryan Kelly [:rfkelly]
	Comment 24 • 8 years ago

I'm WONTFIXing persona-related bugs now that we've committed to decommissioning in the persona.or service.

(We may still need to do this for the new FxA-powered identity stuff, but if so let's bring it back as a nice new clean bug)