Closed Bug 795023 Opened 12 years ago Closed 12 years ago

Use the TrustedUIManager from navigator.id Gaia implementation instead of the PopupManager to trigger a trusted dialog

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

defect

Tracking

(blocking-basecamp:-)

RESOLVED DUPLICATE of bug 794680
blocking-basecamp -

People

(Reporter: jedp, Assigned: zaach)

References

Details

(Keywords: feature, Whiteboard: [LOE:S] [system/trusted_dialog])

In order to implement the payment and identity flows for basecamp, navigator.id needs a trusted UI.

There is already a requirement for a trusted UI for mozPay, and the consensus appears to be that, for v1 at least, it will not be possible to make a generalized trusted ui api that would be available to native services like mozPay, id, etc.

We are fine with copy-and-paste solutions.  But in the end, the flows require a UI for nav.id that looks and acts exactly like the one for mozPay, and provides a way for us to message to and from the native nav.id code.

mozPay trustworthy UI: #768943
Is this a Gaia or Platform bug? It feels Gaiaish.
blocking-basecamp: --- → ?
Keywords: feature
Migrated to Gaia GitHub - https://github.com/mozilla-b2g/gaia/issues/5323, as this is a front-end feature.
Status: NEW → RESOLVED
blocking-basecamp: ? → ---
Closed: 12 years ago
Resolution: --- → INVALID
No longer blocks: basecamp-id
Keeping this bug for project tracking purposes only. 
Developer details and technical requirements in github.

https://github.com/mozilla-b2g/gaia/issues/5323 (assigned to Fernando on the Gaia team)
Blocks: basecamp-id
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
I'd really prefer that we talk this out before you take action, as there's ways we can figure out tracking. But this is still not valid as it stands right now.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → INVALID
Okay, per talking with dietrich, all feature tracking that is v1 also needs to be in bugzilla. Moving this to Gaia in bugzilla and reopening.
Status: RESOLVED → UNCONFIRMED
Component: General → Gaia
Ever confirmed: false
Resolution: INVALID → ---
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [LOE:M]
My apologies for any confusion ferjm that this massive bug churn looks like. So 10/1 and after, they want any v1 tracking done in bugzilla. I'm closing the github issue, migrating the info to here, and starting tracking here.
Assignee: nobody → ferjmoreno
blocking-basecamp: --- → ?
Whiteboard: [LOE:M] → [LOE:M] [system/trusted_dialog]
This bug's scope is limited to making the existing popup UI "trusted."
OS: Mac OS X → All
Hardware: x86 → All
Summary: Implement a trusted ui for navigator.id that functions exactly like the one for mozPay → Use the TrustedUIManager from navigator.id Gaia implementation instead of the PopupManager to trigger a trusted dialog
Whiteboard: [LOE:M] [system/trusted_dialog] → [LOE:S] [system/trusted_dialog]
No longer blocks: 794680
Depends on: 794680
Fernando, how is this coming along?
blocking-basecamp: ? → +
(In reply to Lucas Adamski from comment #9)
> Fernando, how is this coming along?

No work done so far. This is blocked by Bug 794680. Once that one lands, this bug should be trivial to implement. It should only be a matter of using the TrustedUIManager instead of the PopupManager as it is currently used in https://bugzilla.mozilla.org/attachment.cgi?id=667617&action=diff#a/apps/system/js/identity.js_sec2
Fernando: I think Zach Carter on my team can handle this if you'd like, following your example on nav.pay, since he's also writing the identity Gaia tests. What do you think? Now that you've created the example, as you say it should be easy :)

Plus, this means one patch, instead of two.
Sounds good.
Assignee: ferjmoreno → zack.carter
Priority: -- → P1
Per today's b2g meeting - at risk features do not block ship. Renoming.
blocking-basecamp: + → ?
(In reply to Jason Smith [:jsmith] from comment #13)
> Per today's b2g meeting - at risk features do not block ship. Renoming.

Ignore my comment here. This was a point of confusion on my part.
Restoring blocking flag.
blocking-basecamp: ? → +
(In reply to Zachary Carter [:zaach] from comment #16)
> PR awaiting review: https://github.com/mozilla-b2g/gaia/pull/5854

I've attached the PR to Bug 794680 and ask for r? to Vivien.
Closing. See Bug 794680.
Status: NEW → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Talked to Zach about this in b2gpay - duping instead.
Resolution: FIXED → DUPLICATE
blocking-basecamp: + → -
No longer blocks: basecamp-id
You need to log in before you can comment on or make changes to this bug.