Fernando Jiménez Moreno [:ferjm] Reporter
	Description • 12 years ago

We have to implement trusted UI once we have a final UX design.

	Fernando Jiménez Moreno [:ferjm] Reporter
	Comment 1 • 12 years ago

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #0)
> We have to implement trusted UI once we have a final UX design.

I meant trusted UI animations.

	Jason Smith [:jsmith]
	Comment 2 • 12 years ago

P1 nomination - required for payments v1 feature as part of the UX spec.

	Jason Smith [:jsmith]
	Comment 3 • 12 years ago

This will probably get asked in triage, but clarity - is this bug basically tracking - "Whatever pieces of the trusted UI final UX that isn't implemented yet for v1, implement it"

	Jason Smith [:jsmith]
	Comment 4 • 12 years ago

Josh - Can you give the run down of what's needed here and what must be done for v1?

	Alex Keybl [:akeybl]
	Comment 5 • 12 years ago

Waiting to make a final decision on Josh's response here.

	Jason Smith [:jsmith]
	Comment 6 • 12 years ago

Over to Casey while Josh is on PTO.

	Josh Carpenter [:jcarpenter]
	Comment 7 • 12 years ago

This bug pertains to the Trusted UI animations for situations including: 

* Open new Trusted UI flow
* Close a Trusted UI flow
* Switch to Task Manager from a Trusted UI flow
* Switch to a Trusted UI flow from Task Manager
* Incoming call receive during a Trusted UI flow

...etc. I spoke w/ TEF UX about this in London last week but was unable to capture our discussion points into doc before leaving for PTO. I'm back now, and will discuss directly with Alberto tomorrow (Friday Nov 2), in advance of next week's SF Work Week.

	Faramarz Rashed
	Comment 8 • 12 years ago

:clee please make a product call here as well.  this sounds like a feature which hasn't been implemented yet.

	Jason Smith [:jsmith]
	Comment 9 • 12 years ago

I thought we decided yesterday that this was necessary when I talked with various parties. Don't understand why this was marked with a minus. If more info is needed to make a call, please flag needsinfo.

	Jason Smith [:jsmith]
	Comment 10 • 12 years ago

If I understand the intention of this bug, this is basically implement the UX spec changes required for trustworthy UI, as the current implementation just implemented trustworthy UI pieces to be enough to get the pieces up and running. 

Is my understanding correct?

	Chris Lee [:clee]
	Comment 11 • 12 years ago

Josh, do you mind posting the spec and let's plan to discuss this on Mon in SF.  I'm marking this back to a nom and then we can make a call.

	Lucas Adamski [:ladamski]
	Comment 12 • 12 years ago

The feature has been implemented but is awaiting final UX.  Either way this is blocking because we need the spec to understand how close we may or may not be.

	Josh Carpenter [:jcarpenter]
	Comment 13 • 12 years ago

Alberto and I met on this today in SF. We'll confer with Chris Lee to determine blocking +/-.

	Jason Smith [:jsmith]
	Comment 14 • 12 years ago

I don't follow the minus here. Comment 11 implies that we should leave this nomed. Am I misreading something here?

	Caitlin Galimidi [:c8o]
	Comment 15 • 12 years ago

Lucas: please help determine if this needs to be included to support the Payments/Id work.

	Jason Smith [:jsmith]
	Comment 16 • 12 years ago

(In reply to Caitlin Galimidi from comment #15)
> Lucas: please help determine if this needs to be included to support the
> Payments/Id work.

Right. This is planned to be talked about at 12pm tomorrow. I'll see if I get a vidyo session up and running in the hotel in case other folks not at the work week want to attend.

	Lucas Adamski [:ladamski]
	Comment 17 • 12 years ago

This is blocking insofar UX needs to provide the authoritative flow for transitions/animations.  It may be exactly what we already have, but either way we need it.

	Jason Smith [:jsmith]
	Comment 18 • 12 years ago

Spoke with Chris on this - this falls in alignment with what Lucas has stated above. We may not need all of the animations flow Josh has specified (depending on what gets called in vs out of scope), but no matter what, we're going to need something.

Therefore, this is a blocker, as we're going to something here no matter what (even if it's small).

	Jason Smith [:jsmith]
	Comment 19 • 12 years ago

Per talking with a few people also this apparently isn't a feature, it's a user perception problem of understanding of a trusted context.

	Alex Keybl [:akeybl]
	Comment 20 • 12 years ago

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "known P2 bugs found before or during C1".

	alberto.pastor Assignee
	Comment 21 • 12 years ago

Pointer to Github pull-request

	Fernando Jiménez Moreno [:ferjm] Reporter
	Comment 22 • 12 years ago

Comment on attachment 681627 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6410

Thanks Alberto! Great work!

r=me,basiclines with the comments that Ismael and me left in the PR addressed, please.

	Fernando Jiménez Moreno [:ferjm] Reporter
	Comment 23 • 12 years ago

https://github.com/mozilla-b2g/gaia/commit/c07be76497a9231b97faf260089c2f4aa3b91d84

	Jason Smith [:jsmith]
	Comment 24 • 12 years ago

Finished testing this with a basic functional test pass, with the exception of testing keyboard input within a trusted context - which I'll take care of when I test identity integration. Bugs are filed and linked to this bug for followups.

Marking as verified.

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 25 • 10 years ago

The change in cards view make me confused. What's the detail spec about 
* Switch to Task Manager from a Trusted UI flow
* Switch to a Trusted UI flow from Task Manager
We are going to develop task manager to replace cardsview in 2.0 but this old code have something broken like bug 995039. We need detail spec to fix it or redesign it for 2.0 task manager.

	Stephany Wilkes
	Comment 26 • 10 years ago

Flagging Francis for starters as this affects Task Manager.

	Francis Djabri [:djabber]
	Comment 27 • 10 years ago

This seems more like questions the Trusted UI owner should answer. Stephany, who owns this?

	Stephany Wilkes
	Comment 28 • 10 years ago

Neither I nor Jaime know. Flagging Mike to double check. Seems like Omega or Harly could tackle this until we get someone assigned officially for the next release.

	Harly Hsu[:harly]
	Comment 29 • 10 years ago

Since I have no previous knowledge of Trusted UI, here is what we proposed based on what we have observed:
- Trusted UI should be full screen instead of a dialog
- Placed Cancel & Continue button on the header
- Should use the same animation as activity
- Switch to task manager should still display Trusted UI screen
- Tap Trusted UI from task manager should go to Trusted UI screen