Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Description • 12 years ago

Currently, marionette test events do not appear as native events to the DOM, which prevents us from testing code that checks whether it is handling user input (see Bug 821740).

nsDOMIdentity's navigator.id.requet() method checks that it is handling user input.  In order for native identity and marketplace testing to proceed on b2g, we need a workaround.

I suggest we create a pref like dom.identity.syntheticEventsOk that we can set when testing.

When Bug 821740 is resolved, we will be able to remove this pref.

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 1 • 12 years ago

The pref can be set from a marionette test as follows:

self.marionette.execute_script(
    """SpecialPowers.setBoolPref("dom.identity.syntheticEventsOk", true);""")

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 2 • 12 years ago

Forgot you need to check for existence of user pref before querying its value

	Ben Adida [:benadida]
	Comment 3 • 12 years ago

Comment on attachment 693185 [details]
check for syntheticEventsOk pref

wish Marionette could do the truly correct thing, but barring that, this looks good.

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 4 • 12 years ago

r=benadida

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 5 • 12 years ago

Ryan, hg doesn't like the date on my patch :(

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 6 • 12 years ago

Fixed date string in header

(how do you do timezones in header dates?)

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 12 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/1114846b3791

	Ed Morley [:emorley]
	Comment 8 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/1114846b3791

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 9 • 12 years ago

Comment on attachment 693609 [details] [diff] [review]
argh - date string in header was invalid

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 821740
User impact if declined: Automated testing won't be possible for identity and marketplace
Testing completed: marionette test suite
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: none

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 10 • 12 years ago

I've requested that this land in b2g18 so we can perform automated tests of identity and marketplace (whose flow depends on identity).

	Jed Parsons (use needinfo, please) [:jedp, :jparsons] Assignee
	Comment 11 • 12 years ago

... this will not be necessary if QA works with latest builds we make here; only if they want to do automated testing on what the OEMs get with v1.

	Jonathan Griffin (:jgriffin)
	Comment 12 • 12 years ago

Requesting tef+, see comment #9; without this we won't be able to run identify tests on mozilla-b2g18.

	Jason Smith [:jsmith]
	Comment 13 • 12 years ago

(In reply to Jonathan Griffin (:jgriffin) from comment #12)
> Requesting tef+, see comment #9; without this we won't be able to run
> identify tests on mozilla-b2g18.

That would be a case to track, not block actually. This wouldn't stop ship of the phone.

	Andrew Overholt [:overholt]
	Comment 14 • 12 years ago

It seems that the main reason to take this for B2G v1.0.0 would be to prevent regressions but since we're taking *very* few patches there, let's not take this now.  I'm leaving the nom for 1.0.x triage.

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 15 • 11 years ago

Comment on attachment 693609 [details] [diff] [review]
argh - date string in header was invalid

Please go ahead with uplift to the tip of mozilla-b2g18 branch for v1.0.1

	Ryan VanderMeulen [:RyanVM]
	Comment 16 • 11 years ago

https://hg.mozilla.org/releases/mozilla-b2g18/rev/185c947cda31