krupa raj[:krupa] Reporter
	Description • 12 years ago

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/developers/app/private-yacht/payments/ as one of the users (kraj@mozilla.com)
2. Notice the payment account associated with that app
3. Load the same link as an admin not associated with that account.

expected behavior:
The Payment account associated with an app doesn't change based on the user viewing the page.

observed behavior:
Payments account associated with an app changes based on the user.

As an owner, I see that the app is associated with my payment account and when cvan views the same account, there are no payment accounts associated with that app.

	Christopher Van Wiemeersch [:cvan]
	Comment 1 • 12 years ago

http://cl.ly/image/1w1a0V0U170d/o

	Kumar McMillan [:kumar]
	Comment 2 • 12 years ago

does this happen for non-admin accounts in any way? Otherwise, this is probably low priority. There will only be a few mkt admins.

	Andy McKay
	Comment 3 • 12 years ago

The payment accounts are attached to a user not the app. This allows users to re-use their payment account.

This will affect apps where they have multiple developers, or admins or reviewers visiting.

If a developer with access visits this page, they'll should the accounts listed to them. But also show clearly which account is active for this app, even if it's not one of theirs.

	Matt Basta [:basta]
	Comment 4 • 12 years ago

The resolution that krupa agreed to:

> Only the owner of the app can change the payment account.

For everyone else, the field will be present but disabled. Team members cannot remove the app from an "incomplete" state; the owner is the only one that can do that.

	Andy McKay
	Comment 5 • 11 years ago

Adding to this milestone because its a P2.

	scolville Assignee
	Comment 6 • 11 years ago

r? https://github.com/mozilla/zamboni/pull/949

	scolville Assignee
	Comment 7 • 11 years ago

https://github.com/mozilla/zamboni/commit/21e39721203234efea4e84a12aa37d4dc827886d

QA Notes:

To test this it's worth looking at Compatibility and Payments from the following perspectives:

 * Admin (Can't edit the payment account but can see the one associated with the app)
 * Dev (Can't edit the payment account but can see the one associated with the app).
 * Owner (Can update the payment account)
 * 2nd owner (An app which has more than one owner - should be able to update the payment account to one of your own accounts)

	Victor Carciu
	Comment 8 • 11 years ago

Verifed as fixed for all scenarios presented in comment #7.